parallel data provider does not work correctly with injected stages

[adrian-herscu]

Current State
Parallel data provider does not work correctly with injected stages.

How to make it better
Per documentation it seems parallel issues were fixed in JGiven 1.3.0.
However, this requires dropping support of JDK 8 and reworking part of the report generators since the model was changed a bit.

[adrian-herscu]

TNG/JGiven#829

[adrian-herscu]

TNG/JGiven#883

[adrian-herscu]

There are dependencies which are still not modularized in JDK 11 sense, causing qa-jgiven-commons to fail building:

03:06:52 [INFO] --- compiler:3.11.0:testCompile (default-testCompile) @ qa-jgiven-commons ---
03:06:52 [WARNING] Can't extract module name from batik-script-1.14.jar: Provider class org.apache.batik.bridge.RhinoInterpreterFactory not in module
03:06:52 [WARNING] Can't extract module name from json-path-assert-2.5.0.jar: json.path.assert: Invalid module name: 'assert' is not a Java identifier
03:06:52 [WARNING] Can't extract module name from java-8-matchers-1.9.jar: java.8.matchers: Invalid module name: '8' is not a Java identifier
03:06:52 [WARNING] Can't extract module name from xalan-2.7.2.jar: Provider class org.apache.bsf.BSFManager not in module
03:06:52 [INFO] Compiling 15 source files with javac [debug release 11 module-path] to target\test-classes
03:06:53 [INFO] -------------------------------------------------------------
03:06:53 [ERROR] COMPILATION ERROR :
03:06:53 [INFO] -------------------------------------------------------------
03:06:53 [ERROR] module not found: org.openqa.selenium.core
03:06:53 [ERROR] module not found: httpcore
03:06:53 [ERROR] module not found: httpclient

https://stackoverflow.com/questions/67588895/porting-maven-project-from-jdk-8-to-higher
https://issues.apache.org/jira/projects/MCOMPILER/issues/MCOMPILER-464

[adrian-herscu]

Parallel data providers not supported in 1.3.0
TNG/JGiven#829 (comment)

[adrian-herscu]

JGiven stage injection does not work well when activated via multiple threads.

TNG/JGiven#829
TNG/JGiven#491

The only workaround so far is to use dynamic stages.

In the base scenario class there should be protected methods returning each of required stages, like this:

    protected XxxxxElasticSearchActions<?> elasticSearchActions() {
        return addStage(XxxxxElasticSearchActions.class);
    }

Note that JGiven's before/after annotations will not work, hence must call these methods directly on returned stage. See TNG/JGiven#1447

Then, in scenario code:

        elasticSearchVerifications().then()
            .the_xxxx(testData.request.id,
                is(Xxxxx.from(testData.request)));