Update yarn from version 1.22.21 to 3.4.1 and webpack-dev-server from 3.11.1 to 4.0.0 #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuzz
force-pushed
the
upgrade-webpack-dev-server
branch
from
843fbc9
to
276766b
Compare
tuzz
force-pushed
the
upgrade-webpack-dev-server
branch
from
276766b
to
2ed0187
Compare
tuzz
temporarily deployed
to
previews/upgrade-webpack-dev-server
GitHub Actions
Inactive
|
tuzz
force-pushed
the
upgrade-webpack-dev-server
branch
from
2ed0187
to
eb36b95
Compare
tuzz
force-pushed
the
upgrade-webpack-dev-server
branch
from
eb36b95
to
3eee6fe
Compare
tuzz
force-pushed
the
upgrade-webpack-dev-server
branch
from
3eee6fe
to
bee069a
Compare
tuzz
force-pushed
the
upgrade-webpack-dev-server
branch
from
bee069a
to
b7274a3
Compare
|
tuzz
force-pushed
the
upgrade-webpack-dev-server
branch
from
b7274a3
to
cf63e46
Compare
|
tuzz
force-pushed
the
upgrade-webpack-dev-server
branch
from
cf63e46
to
55e3e4c
Compare
|
tuzz
force-pushed
the
upgrade-webpack-dev-server
branch
from
55e3e4c
to
d1ec6a3
Compare
|
tuzz
force-pushed
the
upgrade-webpack-dev-server
branch
from
d1ec6a3
to
ae66738
Compare
tuzz
temporarily deployed
to
previews/upgrade-webpack-dev-server
GitHub Actions
Inactive
|
We’re running into a problem with the string-width dependency. A comment from this GitHub issue suggests upgrading yarn to version 3. storybookjs/storybook#22431
tuzz
force-pushed
the
upgrade-webpack-dev-server
branch
from
ae66738
to
16f2b36
Compare
tuzz
temporarily deployed
to
previews/upgrade-webpack-dev-server
GitHub Actions
Inactive
|
tuzz
changed the title
We need to be able to conditionally set headers for pyodideWorker.js in pull request #893 but this feature isn’t supported in webpack-dev-server 3.x.x. We therefore need to upgrade to version 4.0.0 which allows a function to be provided in the headers option. I’ve tried to follow the migration guide here: https://github.com/webpack/webpack-dev-server/blob/master/migration-v4.md
tuzz
force-pushed
the
upgrade-webpack-dev-server
branch
from
16f2b36
to
a2f26e4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to be able to conditionally set headers for pyodideWorker.js in pull request #893 but this feature isn’t supported in webpack-dev-server 3.x.x. We therefore need to upgrade to version 4.0.0 which allows a function to be provided in the headers option. When attempting this upgrade, I ran into this issue and only managed to resolve it by also updating yarn to version 3.
I’ve tried to follow the migration guide here:
https://github.com/webpack/webpack-dev-server/blob/master/migration-v4.md