Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(YouTube - Keyword filter): Allow two letter keywords #3589

Closed
3 tasks done
aisptn opened this issue Aug 28, 2024 · 2 comments · Fixed by #3592 or #3559
Closed
3 tasks done

feat(YouTube - Keyword filter): Allow two letter keywords #3589

aisptn opened this issue Aug 28, 2024 · 2 comments · Fixed by #3592 or #3559
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@aisptn
Copy link

aisptn commented Aug 28, 2024

Feature description

No response

Motivation

use case: hide videos with "AI" in the title

Acknowledgements

  • I have checked all open and closed feature requests and this is not a duplicate
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@aisptn aisptn added the Feature request Requesting a new feature that's not implemented yet label Aug 28, 2024
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Aug 28, 2024

The issue with 2 letter keywords is word boundaries are currently not considered.

So filtering ai will also hide videos with the words fair, fail, aided and so on. So you would experience a lot of videos set hidden incorrectly.

This behavior is always present with any keywords, but larger words have much less false positives.

I think the searching could check if the keyword match is not surrounded by any other letters, so fair would not be filtered, but @AI-123 and is AI dumb? would be filtered. Then the minimum keyword length could be removed. This has some nuances to correctly handle Unicode foreign letters, but it should be simple enough.

@LisoUseInAIKyrios
Copy link
Contributor

For the time being you can use ai (one space before, but not after), and it will hide all videos with ai except from videos where it's the first word of the title. It seems to hide almost all videos.

Of note, trailing spaces after keywords are removed to cleanup bad user input.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat: keyword filter should allow two-letter word feat(YouTube - keyword filter): Allow two letter keywords Aug 28, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title feat(YouTube - keyword filter): Allow two letter keywords feat(YouTube - Keyword filter): Allow two letter keywords Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
2 participants