-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:RedditSync - Path /u/ requests to use /user/ endpoint #3634
Comments
Can I offer a $50 USD bounty for this to be patched? |
Claiming (I already have changes locally that fix it, because I use Sync myself) |
I DM'd you on reddit. Once the fix is live, send me your contact info to send the bounty. |
Here's the patch in action: WsaClient_poqZwEQTx1.mp4 |
Thanks! I replied to your DM on reddit btw! |
Implemented with 46d11f3 |
I just checked this issue and my unpatched app and is working fine. |
Huh that's weird, it also started working again for me, without the new patch. Wasn't working as of an hour ago. |
It was a known bug on Reddits end confirmed by Reddit devs a couple days ago. It was bound to be fixed like the other login bugs caused by Reddit in the past. (The server returned 500, an internal error). The patch is not needed anymore and can be removed, but it won't make any difference if used. |
Does you new patch have a check to see if the app receives a 500 error, to then use /user instead? If it does, maybe we can still implement it as a backup. |
No, it simply changes the endpoint to /user. I think it's even the "new" endpoint and /u/ is deprecated but exists for backwards compatibility reasons. Should me mentioned in the docs |
I just went over the API docs, and it seems like @oSumAtrIX is correct. I think we should implement this patch as the API docs only reference /user/ and not /u/ My thinking on this is that it's only a matter of time until /u/ may break again causing another need fix in the future. What does everyone else think? |
It won't make a difference. u/ wont break unless Reddit decides to drop backwards compatibility support at which point dozens of other apis would be broken and would need heavy fixing |
I think we should have the patch available. If /user/ is the canonical URL then it gives the option to patch for future use. |
I'll keep it for now as it doesn't break anything but maybe the patch should be renamed to what it does, as it's called a fix whereas it doesn't fix current issue |
Feature description
Patch Reddit Sync to use /user/ endpoint instead of /u/
https://reddit.com/u/spez/about.json (500 error)
vs
https://reddit.com/user/spez/about.json (works fine)
Motivation
Currently the About section in sync is broken for users because the endpoint provides a 500 error.
It's important because sync breaks on the user profile page.
Acknowledgements
The text was updated successfully, but these errors were encountered: