feat(YouTube): Support versions 19.25 and 19.34
#3629
Conversation
…ilar to `iOS` and `Android VR`
|
All patches are version bumped, except for The YT code for old seekbar thumbnails is removed after 19.16, so there's no way a patch can force it on. Do any versions between 19.16 and 19.31 also work? |
|
Since old seekbar patch will remain at 19.16, that means the recommended version will still show as 19.16, but I think for now that is good. There is many changes and so many a/b tests in the recent YT versions that it's almost certain some users will experience half broke patch functionality or run into new annoying content that has no removal patch. So it's better to recommending 19.16 unless a user wants to opt in to brave patching the latest. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
LisoUseInAIKyrios
force-pushed
the
feat/yt-bump
branch
from
52cb281
to
3073fd3
Compare
src/main/kotlin/app/revanced/patches/youtube/misc/litho/filter/LithoFilterPatch.kt
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
LisoUseInAIKyrios
changed the title
~19.31~19.30
This comment was marked as resolved.
This comment was marked as resolved.
LisoUseInAIKyrios
changed the title
19.25 and 19.3719.25 and 19.34
…-bump # Conflicts: # src/main/kotlin/app/revanced/patches/youtube/layout/hide/shorts/HideShortsComponentsResourcePatch.kt
|
Off topics but does anyone got this? |
|
@zainarbani I have Premium and I've never seen that. But I don't ever remember seeing any new features offered to my account. |
Same, Just looking for "Ask about this video" on decompiled 19.38 and nothing matches 😅 |
It could be server-sided, because A.I is generated via server. |
|
I think this is ready to merge. But at the same time, there is no hurry to merge since there isn't anything different with 19.34 except the seekbar thumbnails is worse. I've gone back to using 19.16 just to have old seekbar and swipe to expand/close Modern 1 miniplayer. |
|
I don't even understand why youtube remove the old seekbar and introduces unused features like smart download |
|
@LisoUseInAIKyrios @0xrxL Any idea why cairo settings behave this way? ss
|
If you referring to missing icons, I think because it's still under development. But seems you found a way to add revanced settings button to it. Great... |
Yeah the missing icons, but i think i have completed icons on my previous premium account. |
Good...post a screen here when you can. 👍 |
|
Allowing (or forcing) cairo settings breaks some other patches such as custom seekbar color and I think background playback. |
…opy/paste popup Code adapted from inotia00/revanced-patches@4667cbf
…StandalonePlayerActivityFingerprint` in IntegrationsPatch). Verified relative seek works correctly with tv casting.
|
@zainarbani Google bugged this on manifest, which is the cause of light splashscreen that hurt eyes 🩻 
Just use a different style to fix it 👍 |
|
@0xrxL I have no idea about UI stuff tbh 😅 |
Just in case someone will open an issue related to the "flashing white splashscreen". |
As I mentioned in ReVanced/revanced-patches-template#2178 (comment), modifying AndroidManifest does not apply to root users |
Neither style.xml? Because this fix can be applied to the bugged declared (and used by Manifest) style. |
|
only manifest modification is impossible changes via style.xml are possible |
…-bump # Conflicts: # src/main/kotlin/app/revanced/patches/youtube/interaction/seekbar/DisablePreciseSeekingGesturePatch.kt # src/main/kotlin/app/revanced/patches/youtube/interaction/seekbar/fingerprints/IsSwipingUpFingerprint.kt # src/main/kotlin/app/revanced/patches/youtube/layout/hide/shorts/HideShortsComponentsResourcePatch.kt
Adds support for versions
19.25.38and19.34.42Except for the
Miniplayerpatch, all other targets between19.16and19.34seem to work without any issues. But for simplicity, there is only 2 new recommended versions.Recommended app version
Because of the possibility of unidentified issues and the lack of
Restore old seekbar thumbnailssupport, the recommended app version is still19.16.39Bugs, stability
The recent versions of YouTube have many A/B tests. Both of these new versions may experience more bugs and partially broken patch features. It's also possible you may encounter unidentified ads compared to using
19.16.Seekbar thumbnails
Restore old seekbar thumbnailsis not supported on any version after19.16.39. The code for the old style thumbnails is no longer present and there is no way to restore. If you want the old seekbar thumbnails then continue patching19.16.39.Miniplayer
The modern miniplayers are still under development by YouTube, and as such there can be bugs and issues while using them.
The later targets both add and remove some miniplayer features.
19.25.37adds miniplayer drag and drop and double tap and pinch to increase the miniplayer size. It is also the last version that can expand/close the miniplayer by swiping (must have both drag and drop and double tap turned off), and the last version with 5 second skip forward/back buttons on Modern 1.19.34.42The initial miniplayer size can be specified in the settings. Pinch to resize is always on (cannot be turned off).TODO
Enable slide to seekIntegration changes