Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reposcan/exporter.py dump of modules data indicates logic error somewhere... #485

Open
eherget opened this issue May 8, 2019 · 0 comments
Labels
bug Something that needs to be fixed

Comments

@eherget
Copy link
Contributor

eherget commented May 8, 2019

In exporter.py, dump_modules() method, it builds "pkgerrata2module:<pkg_id>:<errata_id>" entries that are supposed to contain a set of module_ids or module_stream_ids.

What it currently puts in the set is the module_stream_id from the pkg_errata table. The pkg_errata table has a unique constraint on (pkg_id, errata_id), so there can never be more than one value placed in the set with key "pkgerrata2module:<pkg_id>:<errata_id>".

So either this db query was intended to join pkg_errata to module_stream on module_stream_id in order to get the module_id's to put in the set, or there is no need for a set to hold the value keyed on "pkgerrata2module:<pkg_id>:<errata_id>".

@jdobes jdobes added the bug Something that needs to be fixed label Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that needs to be fixed
Projects
None yet
Development

No branches or pull requests

2 participants