Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test vectors #13

Open
hdevalence opened this issue Jun 4, 2018 · 2 comments
Open

Add test vectors #13

hdevalence opened this issue Jun 4, 2018 · 2 comments

Comments

@hdevalence
Copy link
Member

The test vectors section of the website should be filled in.

The website has sections for both the ristretto255 and ristretto448 parameters.

For now I think it's fine just to add test vectors for ristretto255 and not ristretto448, since Decaf also works for Ed448, so there's not really a good reason to use Ristretto there.

Since mdbook allows rustdoc tests, we can make the test vectors executable using the curve25519-dalek reference implementation.

@hdevalence
Copy link
Member Author

The website has test vectors, but they're incorrect (there was a bug in the script that generated them).

The test vectors should ensure that all the edge cases of the hash-to-group operation are exercised, which requires writing down how that operation works (#15, #25)

@hdevalence
Copy link
Member Author

  • Fix ristretto255 test vectors #31 fixes the incorrect test vectors
  • there should be test vectors for the from_uniform_bytes that test the edge cases around stuff like high bits, how the reduction mod p works, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant