Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the forward related to gen_ea_alpha_llama2chat.py fully implemented? #136

Open
YunSeoHwan opened this issue Sep 27, 2024 · 1 comment

Comments

@YunSeoHwan
Copy link

Hi, thanks for your great work!

I am trying to calculate the acceptance length and acceptance rate. So, I ran evaluation/gen_ea_alpha_llama2chat.py. However, an error occurred in the forward process of model/ea_model.py. Currently, the returned variables are outputs, orig, and hidden_states, but utils_alpha.py's initialize_tree requires 5 variables: tree_logits, output, logits, hidden_state, and sample_token. Is that part still not fully implemented? Then, how can I obtain tree_logits?

@zhangtia16
Copy link

I encountered the same issue here. Specifically, there are two points of confusion for me:

1.As YunSeoHwan mentioned, the function “initialize_tree” in utils_alpha.py returns 5 arguments, whereas the “forward” function in ea_model.py outputs only 3 arguments.

2.I noticed that the authors removed the “logits_processor” argument from the “forward” function in ea_model.py in the EAGLE-2 version, compared to the code branch of EAGLE-1. Could the authors please explain why this argument was deleted? I see that “logits_processor” is still being passed into the function call in evaluation/gen_ea_alpha_vicuna.py.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants