Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 'noDebug' support for launch configurations #131

Open
noam-sol opened this issue Jul 6, 2023 · 4 comments
Open

add 'noDebug' support for launch configurations #131

noam-sol opened this issue Jul 6, 2023 · 4 comments

Comments

@noam-sol
Copy link
Contributor

noam-sol commented Jul 6, 2023

Hey :) from dap spec - https://microsoft.github.io/debug-adapter-protocol/specification -

interface LaunchRequestArguments {
  /**
   * If true, the launch request should launch the program without enabling
   * debugging.
   */
  noDebug?: boolean;

  /**
   * Arbitrary data from the previous, restarted session.
   * The data is sent as the `restart` attribute of the `terminated` event.
   * The client should leave the data intact.
   */
  __restart?: any;
}

passing noDebug: true is ignored and the process is debugged (e.g. breakpoints are breaking)

@viewizard
Copy link
Member

This looks like normal application start like dotnet run do. Not sure we could implement this easelly for all supported OSes, since we start it with dbgshim now that also init debug api from the beginning. Even if we will ignore all callbacks from debuggee runtime, this will be not the same as real "no debug"/"normal" launch because debuggee process runtime will be work in another way.

@gfszr
Copy link

gfszr commented Jul 10, 2023

Is there a problem to implement such dotnet run <dll>? If dotnet isn't in $PATH then I guess it can either fail or allow configuring a dotnet installation location via configuration. Having a noDebug option is useful, as it supports DAP output redirection, launching directly from VSCode using the same run configuration and not just compiling and running from a shell.

@viewizard
Copy link
Member

We can't just wrap around dotnet run since not all out targets have dotnet tool at all. From another side we don't plan add CLR corhost implementation inside debugger, as I know.

CC @gbalykov

@gbalykov
Copy link
Member

@noam-sol @gfszr Thank you for interest to the project. We don't have plans for this now, but we are open for contributions if you would like to implement this yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants