Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choice of reference per batch #7

Open
arthur-flam opened this issue May 10, 2020 · 0 comments
Open

Choice of reference per batch #7

arthur-flam opened this issue May 10, 2020 · 0 comments

Comments

@arthur-flam
Copy link
Member

There are some usability improvement we could do for projects where there are multiple batches of results (e.g. denoise, hdr...):

  • Currently, if users select say denoise, then hdr, the reference is still set to denoise. Let's change that! (unless maybe users explicitly selected the reference batch and we can find comparisons...?)
  • There is a request for a feature where we can set different references for different batches. E.g. instead of comparing by default vs the latest commit in master, we could compare hdr vs some milestone, and denoise versus another one... Now, would we specify those preferences in batches.yaml, qaboard.yaml? The main concern is remaining faithful to the likely users' intent and doing it, UI-wise, without surprising them...

In term in implementation,

  • in the app: we want to make sure selected.reference_batch et selected.reference_commit_id can be undefined, and get the reference we want from the batch.data or project config.
  • in the CLI: we need to decide where to read the info and save it.

Bye!
Arthur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant