Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linearized fits rescale to the full data set whenever a fit is performed #3020

Open
butlerpd opened this issue Aug 15, 2024 · 2 comments
Open
Labels
Major Big change in the code or important change in behaviour

Comments

@butlerpd
Copy link
Member

Describe the bug
When performing linearized fits on a data set, hitting fit will reset the graph range to the full range of the data. Worse it seems to be applying the range from the scale of the original data? Either way, since most Linearized plots apply to a small region it becomes very difficult to deal with, particularly since the fit panel is modal (see #3019), requiring the user to close the fit, losing all their work, resetting the zoom factor on the graph then starting the fit panel again. The instructor's comment to me was "At this point users just go use another software when they need to do a linear fit."

Expected behavior
Fitting should have no affect on the graph ranges.

SasView version (please complete the following information):

  • Version: 6.0.0b2

Operating system (please complete the following information):

  • OS: Windows 10

Additional context
Reported during the NIST CNR summer school

@butlerpd butlerpd added Major Big change in the code or important change in behaviour SasView 6.0.0 Required for 6.0.0 release labels Aug 15, 2024
@krzywon krzywon added the Discuss At The Call Issues to be discussed at the fortnightly call label Aug 16, 2024
@krzywon
Copy link
Contributor

krzywon commented Aug 16, 2024

This is present in v5.0.6. Including this in 6.0.0 would likely be scope creep.

@wpotrzebowski wpotrzebowski removed Discuss At The Call Issues to be discussed at the fortnightly call SasView 6.0.0 Required for 6.0.0 release labels Aug 19, 2024
@krzywon
Copy link
Contributor

krzywon commented Aug 22, 2024

This is only happening when the fit is already present on the plot and then replotting. If you zoom in and change the scales, the first fit will keep all plot properties. Subsequent fits will zoom to the default zoom range.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

3 participants