Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unselect all data does not include sub-datasets (Trac #259) #407

Closed
ajj opened this issue Mar 30, 2019 · 7 comments
Closed

Unselect all data does not include sub-datasets (Trac #259) #407

ajj opened this issue Mar 30, 2019 · 7 comments
Assignees
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Milestone

Comments

@ajj
Copy link
Member

ajj commented Mar 30, 2019

For example, if you create an azimuthal average from a 2D dataset, that is a sub-dataset in the data explorer tree. Unselect all (and probably select all etc) does not traverse the tree and include such items.

Migrated from http://trac.sasview.org/ticket/259

{
    "status": "closed",
    "changetime": "2016-10-07T00:12:42",
    "_ts": "2016-10-07 00:12:42.072908+00:00",
    "description": "For example, if you create an azimuthal average from a 2D dataset, that is a sub-dataset in the data explorer tree. Unselect all (and probably select all etc) does not traverse the tree and include such items.",
    "reporter": "ajj",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Bug Fixing",
    "time": "2014-05-18T18:56:17",
    "component": "SasView",
    "summary": "Unselect all data does not include sub-datasets",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 4.0.0",
    "owner": "lewis",
    "type": "defect"
}
@ajj ajj added this to the SasView 4.0.0 milestone Mar 30, 2019
@ajj ajj added Defect Bug or undesirable behaviour Incomplete Migration Major Big change in the code or important change in behaviour and removed Incomplete Migration labels Mar 30, 2019
@butlerpd
Copy link
Member

Trac update at 2014/05/18 19:56:19: butler commented:

yes select also does not work. However given one can generate a lot of those unknowingly it migt be good to have a nuance here. i.e. maybe if the tree is open (i.e. the subsets are visible in the data manager) then select/unselect all should work on them as well while any that are not visible (rolled back up to parent) do not get the selection?

@ajj
Copy link
Member Author

ajj commented Mar 30, 2019

Trac update at 2014/05/18 22:38:44: ajj commented:

Hmm. I would suggest that unselect does all the tree but select only does visible? Or is that too confusing. You can have a lot and so if you've done a plot with lots on, closed them up to see better in explorer and want to plot something new then manually going through all to find the ones that are checked is very annoying....

@ajj
Copy link
Member Author

ajj commented Mar 30, 2019

Trac update at 2015/01/14 12:37:23: ajj changed workpackage from "" to "SasView Bug Fixing"

@sasview-bot
Copy link

Trac update at 2016/08/16 09:45:06:

  • lewis changed owner from "" to "lewis"
  • lewis changed status from "new" to "assigned"

@sasview-bot
Copy link

Trac update at 2016/08/16 10:17:42: Lewis O'Driscoll <lewis.o'drisco commented:

In [e767897]:

#!CommitTicketReference repository="" revision="e767897d6a10f25bfe2bccbef3e3fe6ab0385f7c"
Select/deselct children datasets when select/deselect all is clicked (fixes #407)

@butlerpd
Copy link
Member

Trac update at 2016/09/05 02:37:08:

  • butler commented:

Again fixed by Lewis but "close" in the commit does not actually close ticket. Doing so now

  • butler changed resolution from "" to "fixed"
  • butler changed status from "assigned" to "closed"

@butlerpd
Copy link
Member

Trac update at 2016/10/07 00:12:42: butler changed milestone from "SasView Next Release +1" to "SasView 4.0.0"

@ajj ajj closed this as completed Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

4 participants