Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let a custom model class name differ from its model name (Trac #732) #848

Closed
mdoucet opened this issue Mar 30, 2019 · 1 comment
Closed
Assignees
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Milestone

Comments

@mdoucet
Copy link
Contributor

mdoucet commented Mar 30, 2019

At the moment, the class holding a custom model must have the same name as the name of the model itself. This should be changed to be more flexible.

Migrated from http://trac.sasview.org/ticket/732

{
    "status": "closed",
    "changetime": "2016-10-08T13:45:55",
    "_ts": "2016-10-08 13:45:55.043087+00:00",
    "description": "At the moment, the class holding a custom model must have the same name as the name of the model itself. This should be changed to be more flexible.",
    "reporter": "mathieu",
    "cc": "",
    "resolution": "fixed",
    "workpackage": "SasView Bug Fixing",
    "time": "2016-10-08T13:29:27",
    "component": "SasView",
    "summary": "Let a custom model class name differ from its model name",
    "priority": "major",
    "keywords": "",
    "milestone": "SasView 4.1.0",
    "owner": "mathieu",
    "type": "defect"
}
@mdoucet mdoucet added this to the SasView 4.1.0 milestone Mar 30, 2019
@mdoucet mdoucet self-assigned this Mar 30, 2019
@mdoucet mdoucet added Defect Bug or undesirable behaviour Incomplete Migration Major Big change in the code or important change in behaviour labels Mar 30, 2019
@mdoucet
Copy link
Contributor Author

mdoucet commented Mar 30, 2019

Trac update at 2016/10/08 13:45:55:

  • mathieu commented:

In changeset 2abe6bf:

#!CommitTicketReference repository="sasview" revision="2abe6bf1d6a34a6dfe86ab55d2b0558204c050d8"
Let custom models have different class names. Fixes #848
  • mathieu changed resolution from "" to "fixed"
  • mathieu changed status from "new" to "closed"

@mdoucet mdoucet closed this as completed Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Bug or undesirable behaviour Major Big change in the code or important change in behaviour
Projects
None yet
Development

No branches or pull requests

1 participant