Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TestingStrategy performance #1071

Open
2 tasks done
reneSchm opened this issue Jul 19, 2024 · 0 comments
Open
2 tasks done

Improve TestingStrategy performance #1071

reneSchm opened this issue Jul 19, 2024 · 0 comments
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model.

Comments

@reneSchm
Copy link
Member

reneSchm commented Jul 19, 2024 •
edited
Loading

Motivation / Current Behaviour

TestingStrategy uses somewhat expensive lookups to find entries, which can be replaced as we separated LocationType from LocationId.

Enhancement description

  • Replace scheme storage, e.g. by two vectors (one for type, one for id).
  • Update names, e.g. m_location_to_schemes_map is not a map.

Additional context

See discussion in PR #863, e.g. #863 (comment)

Checklist

  • Attached labels, especially loc:: or model:: labels.
  • Linked to project
@reneSchm reneSchm added loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model. class::improvement Cleanup that doesn't affect functionality labels Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
class::improvement Cleanup that doesn't affect functionality loc::backend This issue concerns the C++ backend implementation. model::abm This issue concerns any kind of agent-based model.
Projects
MEmilio: Agent-Based-Model Development
Status: Product Backlog 📕
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reneSchm