Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Minimum Node Version to 18 #1840

Open
wants to merge 4 commits into
base: v1.x-2022-07
Choose a base branch
from
Open

Move Minimum Node Version to 18 #1840

wants to merge 4 commits into from

Conversation

vlucas
Copy link
Contributor

@vlucas vlucas commented Jul 13, 2022

Description

Ensure that the minimum Node version is 18. This ensures that globals like fetch, formData, etc. are always available.

Node 18 - New globally available browser-compatible APIs

Additional context

Also updated starter templates

@github-actions github-actions bot had a problem deploying to preview July 13, 2022 21:40 Failure
@vlucas
Copy link
Contributor Author

vlucas commented Jul 13, 2022

Looks like we need to poke the Oxygen team to upgrade Node:

error [email protected]: The engine “node” is incompatible with this module. Expected version “>=18". Got “16.16.0”

@frehner
Copy link
Contributor

frehner commented Jul 13, 2022

I think Stackblitz may also only be on 16?

@vlucas
Copy link
Contributor Author

vlucas commented Jul 14, 2022

@frehner That's a good point on StackBlitz. We need to ensure they support Node 18 before we can push this out and then drop all our polyfills.

@vlucas
Copy link
Contributor Author

vlucas commented Jul 14, 2022

I left a comment on the StackBlitz issue for custom Node versions. We will see what they say or do.

@vlucas vlucas changed the title Minimum Node Version is 18 Move Minimum Node Version to 18 Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants