Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Minimum Node Version to 18 #1840

Open
wants to merge 4 commits into
base: v1.x-2022-07
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/oxygen-deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: 16
node-version: 18
cache: 'yarn'

- name: Install the packages
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tests_and_lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
strategy:
matrix:
os: [windows-latest, ubuntu-latest]
node-version: [16.x, 18.x]
node-version: [18.x]

name: OS ${{ matrix.os }} / NodeJS ${{ matrix.node-version }}

Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,8 @@ Spin up a Hydrogen app in your browser with our [playground](https://hydrogen.ne
**Requirements:**

- `yarn` or `npm`
- Node.js version 16.5.0 or higher
- Node.js version 18.0.0 or higher [with globally available browser-compatible
APIs](https://nodejs.org/ko/blog/announcements/v18-release-announce/#new-globally-available-browser-compatible-apis)

**Installation:**

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"packages/playground/*"
],
"engines": {
"node": ">=14"
"node": ">=18"
},
"scripts": {
"dev": "yarn turbo run dev --parallel --filter=@shopify/hydrogen-ui --filter=@shopify/hydrogen",
Expand Down
2 changes: 1 addition & 1 deletion packages/hydrogen/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
} from '@shopify/hydrogen/platforms';

// Platform entry handler
export default function(request) {
export default function (request) {
if (isAsset(new URL(request.url).pathname)) {
return platformAssetHandler(request);
}
Expand Down
3 changes: 3 additions & 0 deletions templates/demo-store/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
"version": "0.0.0",
"license": "MIT",
"private": true,
"engines": {
"node": ">=18"
},
"scripts": {
"dev": "shopify hydrogen dev",
"build": "shopify hydrogen build",
Expand Down
3 changes: 3 additions & 0 deletions templates/hello-world/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
"version": "0.0.0",
"license": "MIT",
"private": true,
"engines": {
"node": ">=18"
},
"scripts": {
"dev": "shopify hydrogen dev",
"build": "shopify hydrogen build",
Expand Down