ADCIRC build support mega-update

[wwlwpd]

Issue 1386:

Related to #1386

Testing list:

Frontera

• v53.05
• v55.01-5bc04d6
• v55.02
• v56.0.2

Lonestar6

• v53.05
• v55.01-5bc04d6
• v55.02
• v56.0.2

Stampede3

• v53.05
• v55.01-5bc04d6
• v55.02
• v56.0.2

Mike III

• v53.05
• v55.01-5bc04d6
• v55.02
• v56.0.2

QBC

• v53.05
• v55.01-5bc04d6
• v55.02
• v56.0.2

QBD

• v53.05
• v55.01-5bc04d6
• v55.02
• v56.0.2

Ubuntu (gfortran)

• v53.05
• v55.01-5bc04d6
• v55.02
• v56.0.2

Ubuntu (OneAPI) (saving this one for last since most of the work was done here)

• v53.05
• v55.01-5bc04d6
• v55.02
• v56.0.2

[wwlwpd]

building this to make sure it didn't break anything

[wwlwpd]

no problems detected

[jasonfleming]

This looks good, and well targeted in the scripting. I have not tried the updated patch sets yet, but will do so now.

[jasonfleming]

@wwlwpd If I build and install ASGS with intel, can I build adcirc with intel-oneapi? Or do they have to match?

[wwlwpd]

@wwlwpd If I build and install ASGS with intel, can I build adcirc with intel-oneapi? Or do they have to match?

It'll have to match. But this is required on Stampede3, so you can try i there on any ASGSes you've built before.

Sorry, this will require building from scratch.

[wwlwpd]

@jasonfleming During the testing above, I discovered that I had to remove -FI for all supported machines for Intel - so it as definitely something new that was introduced with v56 via the src/netcdf_error.F90 file. I ended up removing all instances of -FI in the whole file. I need to test Rostam, but not before this gets merged. Once I finish testing Ubuntu gfortran and Ubuntu with Intel OneAPI, this will be ready for a squash and merge. I am hopeful that will work out just fine, so will now make it ready for review.

[wwlwpd]

There are some other versions in the list I want to remove, but that can also wait.

[wwlwpd]

WWe handle it, but was able to get a clear enough picture of what's going on to submit this bug upstream to ADCIRC regarding their make build system, adcirc/adcirc#408

[wwlwpd]

Note as reference for an issue I will create, but the ADCIRC Live WSL2 VM that is build and distributed currently has the MACHINENAME=wsl-ubuntu - and all the build patches for ADCIRC go off of MACHINENAME=debian - so I will have to address this after this gets merged and I update the adcirclive branch and roll updated VMs.

[wwlwpd]

Testing notes:

Here's the script you can use on Ubuntu:

https://github.com/StormSurgeLive/get-asgs/blob/master/prep/ubuntu-with-oneapi.sh

Note: you'll need to source the Intel .sh file or logout, back in again since that script adds a line to ~/.bashrc to do so

  . ~/.bashrc
  which ifort # should return ifort path

now move on to fresh install of ASGS ...

  git clone [email protected]:StormSurgeLive/asgs.git asgs-oneapi
  cd asgs-oneapi
  git checkout issue-1386 # for now
  ./init-asgs.sh
  # select "debian" on Ubuntu (should be detected)
  # <enter> through the Yes
  # specify "intel-oneapi"
  # ... move through the rest of the wizard and do Y to run build command

You should be able to build with no issues,

• v53release
• v55.01-c*
• v55.02
• v56.0.2

Please let me know if you have any issues or interesting things to report.

[wwlwpd]

I rebased this with master after merging #1386.