Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Gradle Plugin to make it simpler to use #116

Open
ftomassetti opened this issue Dec 15, 2023 · 3 comments
Open

Revise Gradle Plugin to make it simpler to use #116

ftomassetti opened this issue Dec 15, 2023 · 3 comments

Comments

@ftomassetti
Copy link
Member

It should require minimal or no configuration out-of-the-box, while making possible to disable magic that could break

@ftomassetti
Copy link
Member Author

ftomassetti commented Dec 15, 2023

For example,

  • task generateKotlinGrammarSource should be created
  • dependencies on generateKotlinGrammarSource should be set for other tasks.
  • source sets should be configured
  • Also, the README should be updated to reflect that.

@lppedd
Copy link
Contributor

lppedd commented Dec 15, 2023

You can assign this one to me in case.

I'll take a look in a couple weeks.

@frett
Copy link
Contributor

frett commented Jan 10, 2024

I have a rough plugin implementation over here that could be used as a basis for this issue: https://github.com/CruGlobal/kotlin-mpp-godtools-tool-parser/blob/antlrUpdate/build-logic/src/main/kotlin/org/cru/godtools/shared/gradle/KotlinAntlrPlugin.kt

There is an issue with android lint tasks for a few test sourcesets depending on the antlr task output for some reason in my project. It might just be that the generated source needs to be attached to the source set differently 🤷 but I'm not sure and don't have the time currently to debug this or figure out a better solution. I worked around the issue for now by defining which sourcesets to apply the plugin to via the extension.

The other task settings should probably also be exposed via the extension so they can be configured when the plugin is applied

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants