Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve mismatch formatting #109

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

improve mismatch formatting #109

wants to merge 5 commits into from

Conversation

RohrerF
Copy link
Member

@RohrerF RohrerF commented Oct 5, 2020

Summary of the changes

  • mismatch formatting improved when one property doesn't match. if there are multiple Properties not matching it will only show the first one
    image

Addresses #42

@RohrerF RohrerF requested a review from nscheibe October 5, 2020 07:51
@RohrerF
Copy link
Member Author

RohrerF commented Oct 5, 2020

@nscheibe downside of this solution is that we have to switch from Assert.Equals to Assert.True since XUnit does not support a custom message on Assert.Equals

@nscheibe
Copy link
Member

nscheibe commented Oct 5, 2020

Okay let me check it tonight. The only important thing is, that the same exception is thrown (otherwise its a breaking change)... But if its Assert.Equal or Assert.True... I personally dont care :)

@RohrerF
Copy link
Member Author

RohrerF commented Oct 5, 2020

The exception will change that's why some tests are failing

@glucaci
Copy link
Member

glucaci commented Feb 27, 2021

Are you still on this @RohrerF ?

@glucaci
Copy link
Member

glucaci commented Feb 27, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants