Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle partial/failed write in the index file #10

Open
Thomasdezeeuw opened this issue Aug 25, 2020 · 0 comments
Open

Handle partial/failed write in the index file #10

Thomasdezeeuw opened this issue Aug 25, 2020 · 0 comments

Comments

@Thomasdezeeuw
Copy link
Owner

Currently if the Index file has an incorrect length it will refuse to open the file:

stored/src/storage/mod.rs

Lines 1082 to 1086 in d3604d0

} else if (length as usize - INDEX_MAGIC.len()) % size_of::<Entry>() != 0 {
return Err(io::Error::new(
io::ErrorKind::InvalidData,
"incorrect index file size",
));

However we should handle it more cleanly, ignoring the last partial/invalid entry for example. This will require more checks on the index entries themselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant