Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Song files that do not contain linebreaks are ignored #895

Open
bohning opened this issue Sep 9, 2024 · 2 comments
Open

Song files that do not contain linebreaks are ignored #895

bohning opened this issue Sep 9, 2024 · 2 comments

Comments

@bohning
Copy link
Collaborator

bohning commented Sep 9, 2024

Actual behaviour

Songs that do not contain a single linebreak are not loaded (ERROR: Error loading file: Can't find any linebreaks in "/T/The Simpsons - Theme Song/The Simpsons - Theme Song.txt"

Expected behaviour

Songs without linebreaks should be loaded (even if it's an edge case).

Steps to reproduce

Try to load https://usdb.animux.de/index.php?link=detail&id=25978 in USDX.

@barbeque-squared
Copy link
Member

Just to clarify: this issue is about:

  • current USDX behaviour = song needs 2 or more sentences
  • wanted/expected USDX behaviour = song needs 1 or more sentences

if I'm interpreting it correctly? mostly because 0 just doesn't make any sense imo

@basisbit
Copy link
Member

basisbit commented Sep 9, 2024

Also see UltraStar-Deluxe/format#64 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants