-
-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bulk handling for suggestions #671
Comments
Would like to see this too! We added 7 languages, each with about 800 strings to translate. I've spend hours accepting :P |
This looks to me like a duplicate of #849. |
It would be great if there was a "zen mode" for not only reviewing a large number of suggestions but also bulk approving all the suggestions in the language. ie having an "Approve All Suggestions" button. |
My implementation exzhawk@ce51069 |
@exzhawk Avatars is a great idea. To solve the issue of all fields then looking the same, I think a suggestion colour would set it apart from the other fields. The copy, and clone buttons might be more useful than clicking(?) to edit, and then clicking the checkmark? |
Workaround in Python: #8554 (comment) |
Is it something that is accepted as a feature? If it just needs an actual implementation, I could try to create a PR. |
@juliancoffee Yes, it is accepted that we need such a feature. The exact design was not yet discussed, so please post your proposal here before implementing so that feedback can be provided. |
Well, I quite like the design in #671 (comment). It seems to include both a "Suggest" button with an exclamation sign, as well as all suggestions with accept/accept and edit/trash buttons. And looks quite clean. Except, I don't think we need to have suggestions to be different colours or smth, having an avatar and all the buttons gives IMO enough information to differentiate between current translation and suggestions. And maybe add a vote button along with accept/accept and edit/trash. (which also can be pushed slightly up, to avoid hiding the message behind) |
Yes, that makes sense. I think the main question is whether to make it available in the zen mode, or it would be a separate view for dealing with the suggestions. I can see benefits in both approaches. Having it included makes the suggestions available while translating. Having it separate can make the UI more streamlined for suggestions removing not needed parts. |
I think we can just dispatch on whether the user has translation rights? |
User having permission to accept suggestions will often have also permission to edit the translation, so that is IMHO not the way to decide this. |
Yeah, I think having them separate might be both simpler to implement (or not) and simpler to use. But we can adjust it afterwards. |
here's a start #11187, I actually went via always showing suggestions and translations at the same time |
A person came to my site and added hundreds of suggestions.
Currently I have to review each suggestion one at a time, and accept them one at a time.
It would be great if there was a "zen mode" for reviewing large number of suggestions.
The text was updated successfully, but these errors were encountered: