Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RATE_LIMITED on "Discussing changesets" #32

Open
yrtimiD opened this issue Jun 25, 2024 · 5 comments
Open

RATE_LIMITED on "Discussing changesets" #32

yrtimiD opened this issue Jun 25, 2024 · 5 comments
Labels
enhancement New feature or request NextGen This issue will be resolved with OpenStreetMap-NG

Comments

@yrtimiD
Copy link

yrtimiD commented Jun 25, 2024

After reverting around 50 changesets within a few minutes with "Auto-discussion" enabled, some discussion comment adding fails with RATE_LIMITED.

@Zaczero
Copy link
Owner

Zaczero commented Jun 28, 2024

Hey! How would you want such situations to be handled? Currently it just skips over the failed discussions.

@yrtimiD
Copy link
Author

yrtimiD commented Jun 28, 2024

Right, challenging situation. First thing I thought about is at least allowing manual retry action. User might need to wait some time before using the retry option. Also, if api response has a clue about lockout period - will be very nice to show it.

@Zaczero
Copy link
Owner

Zaczero commented Jun 28, 2024

With how osm-revert is designed, a manual retry action is not trivial to do. Ideally, osm-revert would parse OSM response headers to understand current rate limits and adjust its operation. However, I couldn't find any public documentation on this. The good news is that OpenStreetMap-NG already supports rate limit headers, so at some point, this issue will be resolved.

@Zaczero Zaczero added enhancement New feature or request NextGen This issue will be resolved with OpenStreetMap-NG labels Jun 28, 2024
@yrtimiD
Copy link
Author

yrtimiD commented Jun 28, 2024

I see. Maybe at least we can linkify changets numbers in the log to make manual discussion adding slightly less painful?

@Zaczero
Copy link
Owner

Zaczero commented Jun 28, 2024

Okay sounds really useful! I have created an issue but I cannot give any ETA on the completion date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request NextGen This issue will be resolved with OpenStreetMap-NG
Projects
None yet
Development

No branches or pull requests

2 participants