Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid shapes of newly created elements #4

Open
Shamann opened this issue Mar 24, 2021 · 1 comment
Open

Invalid shapes of newly created elements #4

Shamann opened this issue Mar 24, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@Shamann
Copy link
Contributor

Shamann commented Mar 24, 2021 •
edited
Loading

A shape of newly created elements is not modified upon shape switching. Reproduced on d5385ec

InvalidShapes
@Mvwivs
Copy link
Contributor

Mvwivs commented Mar 24, 2021

Currently elements created from Stencil are only added to x6 graph. To allow layout calculations/view swithing elements should be added to application state (in this case sh:Shape and sh:Property collection), then state updates are propogated to Canvas, nodes and so on.
Adding nodes to state requires API from Mobx State Tree (@agentlab/sparql-jsld-client), this in turn requires "View" / "View kind" separation implementation #1

@amivanoff amivanoff added the bug Something isn't working label Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@amivanoff @Shamann @Mvwivs