Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(lint): add prealloc #1576

Merged
merged 1 commit into from
Feb 5, 2024
Merged

ci(lint): add prealloc #1576

merged 1 commit into from
Feb 5, 2024

Conversation

rominf
Copy link
Contributor

@rominf rominf commented Feb 3, 2024

About this change—what it does

Add https://github.com/alexkohler/prealloc to find slice declarations
that could potentially be pre-allocated and address linter errors.

This is partial implementation of #858.

Why this way

make + assign pattern was used in codebase already and it works faster than append.

@rominf rominf requested a review from a team February 3, 2024 19:35
@rominf rominf added the no changelog No changelog entries are required for this PR label Feb 3, 2024
@rominf
Copy link
Contributor Author

rominf commented Feb 3, 2024

Feel free to run acceptance tests if needed.

@Serpentiel Serpentiel self-assigned this Feb 5, 2024
@Serpentiel Serpentiel added the enhancement New feature or request label Feb 5, 2024
Add https://github.com/alexkohler/prealloc to find slice declarations
that could potentially be pre-allocated and address linter errors.
Copy link
Contributor

@Serpentiel Serpentiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Serpentiel Serpentiel enabled auto-merge (squash) February 5, 2024 09:14
@Serpentiel Serpentiel merged commit a7918f0 into aiven:main Feb 5, 2024
10 checks passed
@rominf rominf deleted the rominf-prealloc branch February 10, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request no changelog No changelog entries are required for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants