Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to manage Collaborators (users and teams) #30

Open
actuarysailor opened this issue May 22, 2023 · 3 comments
Open

Ability to manage Collaborators (users and teams) #30

actuarysailor opened this issue May 22, 2023 · 3 comments
Labels
enhancement New feature or request feature New functionality.

Comments

@actuarysailor
Copy link
Contributor

actuarysailor commented May 22, 2023

Is your feature request related to a problem? Please describe.
Mostly a feature, but also kind of a bug.

  • Feature because I do not see option to add/remove users or teams as collaborators.
  • Bug because if you do not have the users/teams added as collaborators, adding them as exceptions to rules on branch protection policy does nothing - e.g. the action won't fail, but the users/teams won't get added

Describe the solution you'd like
Ability to specify users and teams to add as collaborators in the settings.yaml

Describe alternatives you've considered
Other repos / GitHub actions - honestly I looked, and yours is the best one out there.

Additional context
None - I may help code this as well.

@andrewthetechie andrewthetechie added enhancement New feature or request feature New functionality. labels May 22, 2023
@andrewthetechie
Copy link
Owner

As long as pygithub supports this api operation, it should be fairly straightforward to add this.

@actuarysailor
Copy link
Contributor Author

@andrewthetechie - I agree; only caveat is when I was debugging why the Policy requirements wouldn't sync, I noticed they are using some old methods or incorrect REST API command types. Note the "checks" box will be replacing "contexts" on the policies in the future.

@actuarysailor
Copy link
Contributor Author

actuarysailor commented May 23, 2023

@andrewthetechie - doesn't look like its supported by pyGitHub - also in looking at the REST API documentation, it doesn't support the roles:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New functionality.
Projects
None yet
Development

No branches or pull requests

2 participants