Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the image preview before adding an image #17119

Open
BrayanDSO opened this issue Sep 23, 2024 · 3 comments
Open

Remove the image preview before adding an image #17119

BrayanDSO opened this issue Sep 23, 2024 · 3 comments
Labels
Needs reviewer reply Waiting for a reply from another reviewer

Comments

@BrayanDSO
Copy link
Member

I don't see its point. If I'm choosing an image from the gallery, I'm already previewing it while selecting it, so there's no need at all to reconfirm that I want the image that I deliberately chose.

Also, showing the file size below it is a mostly useless information and is not user-friendly.

The feature, IMO, is just a annoying extra tap and a loss of time.

If its only usefulness is to give some way for the user to crop it, it can be done in other ways that are more friendly.

@BrayanDSO BrayanDSO added the Needs reviewer reply Waiting for a reply from another reviewer label Sep 23, 2024
@criticalAY
Copy link
Contributor

I would like to counter that, majority of the apps show the preview after picking image from the gallery plus if user wants to add directly image to the field they can just paste it, or what we can do is avoid preview in case user directly shares image to AnkiDroid from gallery

@BrayanDSO
Copy link
Member Author

majority of the apps show the preview after picking image

You need a source or a list of examples if you want to make that argument. I tested every app in my phone that can add images, and none of them had a preview before adding it (Google docs, Keep, Obsidian, TickTick, Samsung notes, Microsoft Office)

That also includes Anki and AnkiMobile.

if user wants to add directly image to the field they can just paste it,

That's complex for most people. And it doesn't invalidate any of the points that I made in the post.

@criticalAY
Copy link
Contributor

criticalAY commented Sep 25, 2024

I was talking about WhatsApp and Telegram, though what about the crop since the apps you mentioned allow to edit the image after we add it,
I want to stick to the previewer till we migrate the note editor in webview as I think it will have preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs reviewer reply Waiting for a reply from another reviewer
Projects
None yet
Development

No branches or pull requests

2 participants