-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using the Fields, Cards, or Deck Selection button causes IO editor to blank out #2619
Comments
This seems to be along the same lines as the previous blanking issues, where we somehow reach an inconsistent state in All of the paths described above call Was not able to look into this further yet, as I'm still on the add-on API work. If one of you has time and would like to pick this up, I'd very much appreciate it 🙏 |
With the merge of #2598 this can now be triggered on the main branch. Hopefully will look into it tomorrow, if nobody beats me to it. |
A call to |
On a related note, would it perhaps make sense to revisit the various IO states in Svelte and look into whether we can simplify them? I'm having a bit of a hard time following how the various states like |
It might be possible to unify imageOcclusionMode and isImageOcclusion? I'm not sure whether the other two could be removed, as I think we need to keep track of whether the mask editor or fields are shown, and need to know whether to show the select image button or show the mask editor |
I too find the current I/O mode-related code a bit hard to follow.
Maybe we can reduce those four and |
I have |
Steps to reproduce:
Expected behavior:
Editor is in the same state as before opening up the dialog.
Actual behavior:
Editor is blank. Switching to a different note type restores the field editor, but switching back to Image Occlusion creates a blank state again. To use the mask editor again, you will have to close the current AddCards/EditCurrent instance and open another one.
Screencast-2023-08-23_19.06.57.mp4
Tested against
main
with 70506ae revertedThe text was updated successfully, but these errors were encountered: