Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.18] rm -rf hacking/tagger #1933

Draft
wants to merge 1 commit into
base: stable-2.18
Choose a base branch
from
Draft

[stable-2.18] rm -rf hacking/tagger #1933

wants to merge 1 commit into from
+0 −421

Conversation

oraNod
Copy link
Contributor

@oraNod oraNod commented Sep 24, 2024

Relates to #1932

@oraNod oraNod changed the title tagger versions [stable-2.18] update tagger versions for stable-2.18 Sep 24, 2024
gotmax23
gotmax23 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@gotmax23 gotmax23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is alright. We could also consider removing the tagger script from stable branches (I think it was never backported to the previous ones). It's not actually needed there.

@oraNod
Copy link
Contributor Author

oraNod commented Sep 24, 2024

The code is alright. We could also consider removing the tagger script from stable branches (I think it was never backported to the previous ones). It's not actually needed there.

Better. I'll do that and backport as the tagger is on stable-2.17 as well.

@oraNod oraNod changed the title [stable-2.18] update tagger versions for stable-2.18 [stable-2.18] rm -rf hacking/tagger Sep 24, 2024
@oraNod oraNod marked this pull request as draft September 24, 2024 13:48
@gotmax23
Copy link
Collaborator

You also need to adjust the LINT_FILES tuple at the top of the noxfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotmax23 gotmax23 gotmax23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oraNod @gotmax23