Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-2.17] support pip-compile check mode and remove pip-compile workflows from stable branch #1947

Open
wants to merge 2 commits into
base: stable-2.17
Choose a base branch
from

Conversation

gotmax23
Copy link
Collaborator

Support a custom --check flag to fail if pip-compile made any changes so
we can check that that lockfiles are in sync with the input (.in) files on all pushes and PRs.

Then, we can also remove the standalone pip-compile workflows from the stable branches as discussed in #1920.

Support a custom --check flag to fail if pip-compile made any changes so
we can check that that lockfiles are in sync with the input (.in) files.

(cherry picked from commit cb295b1)
We don't need these on stable branches, as they can be triggered from
the devel branch with a custom base-branch input.
They were also missing backports of various fixes from the devel branch.
Rather than trying to backport all the changes, let's just remove it
from stable branches and make sure we do so after each branching.

(cherry picked from commit 0d8d26e)
@gotmax23 gotmax23 added no_backport This PR should not be backported. devel only. tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves. merge_commit Use "Create a merge commit" when applying this PR labels Sep 26, 2024
@gotmax23 gotmax23 marked this pull request as ready for review September 26, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge_commit Use "Create a merge commit" when applying this PR no_backport This PR should not be backported. devel only. tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant