Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with Jest #31

Open
muhmud opened this issue Nov 7, 2017 · 9 comments
Open

Does not work with Jest #31

muhmud opened this issue Nov 7, 2017 · 9 comments

Comments

@muhmud
Copy link

muhmud commented Nov 7, 2017

Hi,

There's a bug fix for release 0.1.0 in bagpipes/lib/fittingTypes/user.js when using bagpipes with Jest, however, this hasn't been released?

Would that be possible?

Thanks,

@WaldoJeffers
Copy link

Yes @theganyo please; this is absolutely critical for my team. It's basically impossible to require the file where swagger-node is instanciated (usually app.js), making it impossible to test with Jest or other test frameworks.

@theganyo
Copy link
Contributor

theganyo commented Feb 2, 2018

Done! 0.1.1 has been released. Hope this works for you!

@theganyo theganyo closed this as completed Feb 2, 2018
@WaldoJeffers
Copy link

@theganyo works like a charm, thank you!

@muhmud
Copy link
Author

muhmud commented Feb 8, 2018

Works for me too, thanks!

@theganyo
Copy link
Contributor

theganyo commented Feb 8, 2018

@WaldoJeffers @muhmud The patch submitted for this had to be rolled back in 0.1.2 because of regressions. Are you saying that it still works fine or that you're pinning on version 0.1.1?

@WaldoJeffers
Copy link

@theganyo Haven't tried version 0.1.2. To fix my issue, I had to lock my version to 0.1.1 (which was 0.1.0 at the time). Does that help @theganyo ?

@theganyo
Copy link
Contributor

theganyo commented Feb 8, 2018

I was just curious and wanted to give you the heads up as I assume it will no longer work. A better considered and tested PR will be needed before this goes in again.

@WaldoJeffers
Copy link

Okay, thanks. The version is locked down in my yarn.lock file, but thanks for the heads up. Appreciated. Should we re-open this issue or not?

@theganyo
Copy link
Contributor

theganyo commented Feb 8, 2018

Sure. But the issue title is incorrect. I'll reopen and change it.

@theganyo theganyo reopened this Feb 8, 2018
@theganyo theganyo changed the title New release with fix for Jest Does not work with Jest Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants