Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support of URI Fragment #98

Open
swamp-agr opened this issue Jul 19, 2020 · 0 comments
Open

Add support of URI Fragment #98

swamp-agr opened this issue Jul 19, 2020 · 0 comments

Comments

@swamp-agr
Copy link

swamp-agr commented Jul 19, 2020

Hi @aristidb,

Problem statement

I found that URI fragment is missing in the package.

Screenshot 2020-07-16 at 23 15 48

I am talking about secondary part of URI (after hash sign, #). Despite it does not used in HTTP REST API, it is quite useful in HTTP (e.g. as HTML anchor). I would like to have it as a part of http-types just not to introduce it separately in several other packages dependent on this package (e.g. yesod-core).

Motivation

Consider GitHub, e.g. following URL: https://github.com/aristidb/http-types/blob/master/Network/HTTP/Types/URI.hs#L340-L347

While the content of the page with and without anchor remains the same, the page markup is different.

Imagine the situation where I want to introduce server-side rendering for HTML page with similar (highlighting) functionality based on fragment.

Would you like to accept PR with this missing part?

Thanks,
Andrey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant