Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Ruff #543

Open
aloctavodia opened this issue Sep 28, 2024 · 3 comments
Open

Use Ruff #543

aloctavodia opened this issue Sep 28, 2024 · 3 comments
Labels
good first issue Good for newcomers

Comments

@aloctavodia
Copy link
Contributor

We should switch to Ruff for linting and code formatting.

We could follow ArviZ:

@aloctavodia aloctavodia added the good first issue Good for newcomers label Sep 28, 2024
@OriolAbril
Copy link
Member

Note for now arviz-stats uses both ruff and pylint (as pylint has extra rules that have proved useful in arviz-stats). To use only ruff and no pyling the pre-commit config of arviz-base is a better template: https://github.com/arviz-devs/arviz-base/blob/main/.pre-commit-config.yaml

@faresbouzayen
Copy link

Hi @aloctavodia,

I’m happy to take this up! I’ll follow the ArviZ setup and configure Ruff. Should we fully replace Pylint or keep it alongside Ruff as in arviz-stats for now?

Thanks!

@aloctavodia
Copy link
Contributor Author

Thanks @faresbouzayen. Let's try with just ruff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants