Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pymultimonaprs corrupts packet data by trimming whitespace #39

Open
hessu opened this issue May 30, 2020 · 0 comments
Open

pymultimonaprs corrupts packet data by trimming whitespace #39

hessu opened this issue May 30, 2020 · 0 comments

Comments

@hessu
Copy link

hessu commented May 30, 2020

pymultimonaprs removes any leading or trailing whitespace in a packet (space, tab characters). This is packet data corruption; packets should be forwarded unmodified (up to the first CR or LF character).

payload = payload.strip()

line = line.strip()

A valid packet may have whitespace in the beginning or end. Specifically, an APRS packet may well have a space character in the end that conveys information: the Yaesu VX-8 is identified by a space in the end of the packet! See mic-e type codes, http://www.aprs.org/aprs12/mic-e-types.txt

By trimming whitespace a modified duplicate copy is created. The APRS-IS will then have two versions of the same original packet: one which has the spaces, and one which doesn't. Please see hint 1:

https://github.com/hessu/aprsc/blob/master/doc/IGATE-HINTS.md

@hessu hessu changed the title pymultimonaprs trims whitespace from packets pymultimonaprs corrupts packet data by trimming whitespace May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant