Make sure reloading happens after collecting

[akijakya]

Right now there are two workers ran by the reloader, one for collecting data, and another for checking into Vault for the secret versions. One could argue that collecting data frequently doesn't makes sense, because only the latest state of the collected data would count when the reloading actually happens.

Therefore it makes sense to set the same run period for the collector and the reloader workers, e.g. run them every 4 hours. In this case we should make sure the collector runs before the reloader so the reloading would be executed on the latest state of things, and not on 4 hour old data.

[ramizpolic]

I think having the ability to specify the collection/reload periods gives enough space for users to configure reloader based on their own requirements at the moment.
In the future versions, we could use only one (e.g. refresh) period when the collection+reload will occur. It should be done in a way that once all the secrets are collected, a value is sent to a channel that is used to trigger reloader.

vault-secrets-reloader/pkg/reloader/controller.go

Line 125 in 12ea827

go wait.UntilWithContext(ctx, c.runReloader, reloaderPeriod)

This ensures that reload always happens after collection.