Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reloading to be triggerable from outside #37

Open
akijakya opened this issue Oct 19, 2023 · 1 comment
Open

Make reloading to be triggerable from outside #37

akijakya opened this issue Oct 19, 2023 · 1 comment
Assignees
Labels
kind/enhancement Categorizes issue or PR as related to an improvement. lifecycle/keep Denotes an issue or PR that should be preserved from going stale. priority/low Issue that might be added to backlog or be rejected.

Comments

@akijakya
Copy link
Member

akijakya commented Oct 19, 2023

It would be nice to be able to not only run the reloader worker when it is scheduled by configuration, but on other events as well, like after secret-sync synced some new secrets into the local Vault, or by an ops team member manually after they changed a secret etc.

@akijakya akijakya self-assigned this Oct 19, 2023
@ramizpolic
Copy link
Member

ramizpolic commented Oct 24, 2023

We could use CRs to trigger a refresh request and update the CR with details about reloading. The CR could have 4 potential states Created/Empty, InProgress, Succeeded, Failed. However, I would wait out for more feature requests before working on this as in our current use-cases we only need to have reloading capabilities present (rather than enforcing/checking refreshes)

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Dec 24, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 14, 2024
@ramizpolic ramizpolic removed the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Feb 29, 2024
@ramizpolic ramizpolic reopened this Feb 29, 2024
@ramizpolic ramizpolic added the priority/low Issue that might be added to backlog or be rejected. label Feb 29, 2024
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label May 5, 2024
@csatib02 csatib02 removed the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label May 5, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot May 5, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot May 5, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot May 5, 2024
@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. label Jul 7, 2024
@csatib02 csatib02 added kind/enhancement Categorizes issue or PR as related to an improvement. lifecycle/keep Denotes an issue or PR that should be preserved from going stale. and removed lifecycle/stale Denotes an issue or PR that has become stale and will be auto-closed. labels Jul 7, 2024
@bank-vaults bank-vaults deleted a comment from github-actions bot Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Categorizes issue or PR as related to an improvement. lifecycle/keep Denotes an issue or PR that should be preserved from going stale. priority/low Issue that might be added to backlog or be rejected.
Projects
None yet
Development

No branches or pull requests

3 participants