-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API in release-1.11 not usable (protobuf dependency) #806
Comments
Hi @Tanemahuta, Thanks for raising this issue! I think you have a completely valid point that it would be nice if the API was usable without any replace directives. The thing is though that I think we cannot easily require I'd rather consult with @waynz0r about this fork whether we need to keep it or is there a better workaround to handle this dependency. @waynz0r could you please take a look at this once you are back and whenever have time? |
All fine. In the meantime adding that replace directive to the go.mod of the API would be nice 🙌 thank you |
Unfortunately, it doesn't work like that. The other dependencies used in the API go.mod use the
Let us know if you can make it work somehow, but I'm afraid the reality is that you need to replace it in your own project for now. We either fork those other repos and make sure that the forks are used everywhere from the API (which is a way I don't want to go) or find a solution to omit our fork altogether. |
True, I forgot about replace not being transient. Meh. A pity. At least there's a solution and it can be found when searching through the issues. |
@Tanemahuta, this was fixed here for the |
Reopening because of this PR: #868 |
Describe the bug
The protobuf marshaller referenced by the API module is not compatible.
Steps to reproduce the issue:
require github.com/banzaicloud/istio-operator/api/v2 v2.0.0-20211217152025-f1b654fb609f
to your go.mod.Expected behavior
Compiling should succeed.
Additional context
Line in question is
istio-operator/api/v1alpha1/common_json.gen.go
Line 225 in f1b654f
Maybe it would be a good idea to exclude the gogo/protobuf in all your go.mod and require the waynz0r/protobuf as a dependency in the API go.mod.
Workaround
add a
replace github.com/gogo/protobuf => github.com/waynz0r/protobuf v1.3.3-0.20210811122234-64636cae0910
to your project's go.mod.The text was updated successfully, but these errors were encountered: