Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0: consider rename of oci_tarball #629

Closed
alexeagle opened this issue Jun 17, 2024 · 2 comments
Closed

2.0: consider rename of oci_tarball #629

alexeagle opened this issue Jun 17, 2024 · 2 comments
Milestone

Comments

@alexeagle
Copy link
Collaborator

Now that it doesn't produce a tarball as a default output, the name is confusing.

Also since it's a noun, it seems like it should be build'able - but the recommended use is to run it for the side-effect of loading the layers into a daemon. So it should have a verb name like oci_load or oci_daemon_load.

While we do that we should probably rename the output group to oci_tarball so the migration path from 1.x is more clear.

@alexeagle alexeagle added this to the 2.0 milestone Jun 17, 2024
@thesayyn
Copy link
Collaborator

fixed by #636

@alexeagle
Copy link
Collaborator Author

Note, we could also pre-declare an output like [name].tar so you're not forced to go through the filegroup trick to request it. OTOH we want to discourage actually running tar to produce a huge output from an action, so I guess inconvenience is a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants