Skip to content

Commit

Permalink
tracing-core: Do not add valuable/std feature as dependency unless …
Browse files Browse the repository at this point in the history
…`valuable` is used (tokio-rs#3002)

## Motivation

`tracing-core` adds a dependency on `valuable` anytime the `std` (or `default`) feature is enabled even when `valuable` is not meant to be used. This was pointed out by [this comment](tokio-rs#1608 (comment)).

## Solution

Only add the feature dependency when something enables `valuable`.

This does not apply to `master` as `valuable` support there is always on.
  • Loading branch information
mladedav committed Jun 9, 2024
1 parent 36bf063 commit 6d00d7d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tracing-core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ edition = "2018"
rust-version = "1.63.0"

[features]
default = ["std", "valuable/std"]
default = ["std", "valuable?/std"]
std = ["once_cell"]

[badges]
Expand Down

0 comments on commit 6d00d7d

Please sign in to comment.