Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification Misalignment: Discrepancies Between the DSEP spec and the referenced Core Spec #164

Open
rajaneeshk90 opened this issue Jan 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@rajaneeshk90
Copy link

rajaneeshk90 commented Jan 3, 2024

Issue Details:

Problem Statement:
The DSEP specification outlined in the /api folder(link to the DSEP specification definition) references the core spec version 1.1.0, but discrepancies exist in their adherence to the referenced core spec. The discrepancies are listed below.

1. The structure of the DSEP specification deviates from the Beckn core specification in the handling of location information. For instance:

In the Beckn core protocol specification context, the location object encapsulates both city and country:

"location": {
    "city": {
        "name": "Bangalore",
        "code": "std:080"
    },
    "country": {
        "name": "India",
        "code": "IND"
    }
}

However, the DSEP specification does not include a location object within context. Instead, city and country are directly placed inside context:

"country": "IND",
"city": "std:080"

2. The examples that are used in the specification yaml (dsep-v0.7.yaml) are not as per the core-v1.1 specification. Link
3. Unused components are present in the specification yaml. For example, Policy, StructuredAddress, FullAddress, FeedbackUrl, FeedbackFormElement, FeedbackForm & Feedback schema is defined in the dsep-v0.7.yaml but are not used.
4. Rating & on_rating specs is not as per core-v1.1.yaml Link

It is essential to investigate these inconsistencies and rectify the misalignment between the DSEP specification and the referenced Beckn core protocol specification.

@rajaneeshk90 rajaneeshk90 changed the title Specification Misalignment: Discrepancies Between DSEP and Core Spec Version 1.1.0 in Location Handling Specification Misalignment: Discrepancies Between the DSEP spec and the Core Spec Version 1.1.0 in Location Handling Jan 3, 2024
@rajaneeshk90 rajaneeshk90 changed the title Specification Misalignment: Discrepancies Between the DSEP spec and the Core Spec Version 1.1.0 in Location Handling Specification Misalignment: Discrepancies Between the DSEP spec and the referenced Core Spec in Location Handling Jan 3, 2024
@ravi-prakash-v ravi-prakash-v added the bug Something isn't working label Feb 9, 2024
@nirmalnr
Copy link

The PR still has an old version of xInput. Described the same in the comment here: #171 (comment)

@rajaneeshk90 rajaneeshk90 changed the title Specification Misalignment: Discrepancies Between the DSEP spec and the referenced Core Spec in Location Handling Specification Misalignment: Discrepancies Between the DSEP spec and the referenced Core Spec Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants