Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter peers to TCP #162

Closed
wcatz opened this issue Mar 30, 2024 · 1 comment · Fixed by #163
Closed

Filter peers to TCP #162

wcatz opened this issue Mar 30, 2024 · 1 comment · Fixed by #163
Assignees
@wolf31o2
Labels
bug Something isn't working

Comments

@wcatz
Copy link

wcatz commented Mar 30, 2024

P view is displaying my routers DNS server(UDP) on 53 as a peer of cardano-node. It was also picking up the Samba connection(TCP) on 445 on my router that I was mounting in fstab in the node host.
@wolf31o2 wolf31o2 mentioned this issue Mar 30, 2024
Merged
@wolf31o2 wolf31o2 added the bug Something isn't working label Mar 30, 2024
@wolf31o2
Copy link
Member

I dug a bit and process.ConnectionsWithContext will use "all" when getting connections. The ticket switches this to "tcp" to limit it to tcp4 and tcp6 connections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolf31o2 wolf31o2

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: filter peers to tcp connections blinklabs-io/nview
2 participants
@wolf31o2 @wcatz