From 85112f4aa4d6d115c9e8d60475144fbedbaf09cd Mon Sep 17 00:00:00 2001 From: Jan Richter Date: Fri, 20 Sep 2024 12:25:36 +1200 Subject: [PATCH 1/3] fix: key was missing in kafka record Added a getter for missing key property. --- src/Event/Kafka/KafkaRecord.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/Event/Kafka/KafkaRecord.php b/src/Event/Kafka/KafkaRecord.php index 4c97c3d1a..e5174e964 100644 --- a/src/Event/Kafka/KafkaRecord.php +++ b/src/Event/Kafka/KafkaRecord.php @@ -18,6 +18,11 @@ public function __construct(mixed $record) } $this->record = $record; } + + public function getKey(): string + { + return $this->record['key']; + } public function getTopic(): string { From d4b97898e4e72d8fb41e55a81696266155c9ade1 Mon Sep 17 00:00:00 2001 From: Jan Richter Date: Mon, 23 Sep 2024 06:48:45 +1200 Subject: [PATCH 2/3] chore: added tests --- tests/Event/Kafka/KafkaEventTest.php | 1 + tests/Event/Kafka/kafka.json | 1 + 2 files changed, 2 insertions(+) diff --git a/tests/Event/Kafka/KafkaEventTest.php b/tests/Event/Kafka/KafkaEventTest.php index e805f6dc9..9c5011361 100644 --- a/tests/Event/Kafka/KafkaEventTest.php +++ b/tests/Event/Kafka/KafkaEventTest.php @@ -19,6 +19,7 @@ public function test canonical case() self::assertSame(15, $record->getOffset()); self::assertSame(1545084650987, $record->getTimestamp()); self::assertSame('Hello, this is a test.', $record->getValue()); + self::assertSame('SGVsbG8gV29ybGQ=', $record->getKey()); self::assertSame( [ 'type' => 'core', diff --git a/tests/Event/Kafka/kafka.json b/tests/Event/Kafka/kafka.json index 94c14a47f..8d7f15cf1 100644 --- a/tests/Event/Kafka/kafka.json +++ b/tests/Event/Kafka/kafka.json @@ -9,6 +9,7 @@ "offset":15, "timestamp":1545084650987, "timestampType":"CREATE_TIME", + "key": "SGVsbG8gV29ybGQ=", "value":"SGVsbG8sIHRoaXMgaXMgYSB0ZXN0Lg==", "headers":[ { From cffe79fc74e4d748120c2594c8d126b855b22ccd Mon Sep 17 00:00:00 2001 From: Jan Richter Date: Wed, 25 Sep 2024 14:12:05 +1200 Subject: [PATCH 3/3] Whitespace Wipeout: CodeSniffer 1, Spaces 0 --- src/Event/Kafka/KafkaRecord.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Event/Kafka/KafkaRecord.php b/src/Event/Kafka/KafkaRecord.php index e5174e964..841981b82 100644 --- a/src/Event/Kafka/KafkaRecord.php +++ b/src/Event/Kafka/KafkaRecord.php @@ -18,7 +18,7 @@ public function __construct(mixed $record) } $this->record = $record; } - + public function getKey(): string { return $this->record['key'];