Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tumor Types API not supporting forward slash in query #134

Open
gearve14 opened this issue Jul 9, 2018 · 3 comments
Open

Tumor Types API not supporting forward slash in query #134

gearve14 opened this issue Jul 9, 2018 · 3 comments
Assignees
Labels
api changes to the api controller level bug

Comments

@gearve14
Copy link

gearve14 commented Jul 9, 2018

It appears the API is not properly escaping "/" characters as it should. For example, the request url: http://oncotree.mskcc.org/api/tumorTypes/search/name/Desmoid%2FAggressive%20Fibromatosis?version=oncotree_2018_06_01&exactMatch=true&levels=2%2C3%2C4%2C5 does not recognize %2F as an escaped character and thus tries to route to a different directory, instead of returning the result for "Desmoid/Aggressive Fibromatosis".

This seems to only effect forward slashes as I have tested it with other special characters and they all work fine.

@zhx828
Copy link
Member

zhx828 commented Oct 24, 2018

@sheridancbio I ran into similar issue when try to query code MDS/MPN

@sheridancbio
Copy link
Contributor

This bug is verified. Essentially, the controller mapping/routing is mistaking the slash in the parameter text to be division ( a path parameter split ). We will look into the correct technique to escape these slashes so that they do not break up the request argument. We may need to introduce a replacement character approach if there is no natural method available. cc @ritikakundra

@sheridancbio sheridancbio added bug api changes to the api controller level labels Nov 1, 2018
@caaespin
Copy link

Do you guys have an estimate for when this bug would be addressed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api changes to the api controller level bug
Projects
None yet
Development

No branches or pull requests

4 participants