Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concatenated tstr/bstr fragments #16

Open
BrianSipos opened this issue Feb 24, 2021 · 5 comments
Open

Concatenated tstr/bstr fragments #16

BrianSipos opened this issue Feb 24, 2021 · 5 comments

Comments

@BrianSipos
Copy link

The definition in Section G.4 of RFC8610 allows whitespace-separated tstr and bstr fragments to be treated as one whole concatenated value. When I attempt to use this with the tool diag2pretty I get an error shown below. This also happens if the whitespace includes newlines, which is what I was originally trying to do.

*** can't parse "test" "this"
*** Expected one of [ \t\n\r], "/" at line 1, column 8 (byte 8) after 
@cabo
Copy link
Owner

cabo commented Feb 24, 2021

That is a feature of EDN that apparently did not make it into the implementation yet.
This is not too hard to do, so I expect getting to it within a month or so.

@rohanmahy
Copy link

+1

FYI: This is also preventing me from using diag2cbor.rb and diag2pretty.rb directly with examples in Internet-Drafts (because I am trying to make my examples narrow enough to fit in 72 characters).

@cabo
Copy link
Owner

cabo commented Jun 7, 2024

This is also preventing me from using diag2cbor.rb and diag2pretty.rb directly with examples in Internet-Drafts (because I am trying to make my examples narrow enough to fit in 72 characters).

Hi Rohan,

thank you, that is very useful input.
I have prototyped the new ABNF in the edn-abnf tool (gem install edn-abnf).
I waited with updating the cbor-diag tool (and thus also cbor.me) as I didn't want to destabilize that tool set.
Given that we seem to be converging, I could now integrate the edn-abnf parser updates into the cbor-diag code base.

@rohanmahy
Copy link

I will try using the edn-abnf tool.

@cabo
Copy link
Owner

cabo commented Jun 7, 2024

If there is anything missing in edn-abnf that you need for that, please holler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants