Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execute module replacement in a single command #178

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

WeidiDeng
Copy link
Member

When testing http3 graceful shutdown, I found out I can't build caddy with local plugin by xcaddy build http3-graceful --with github.com/quic-go/quic-go=github.com/WeidiDeng/quic-go@graceful-close --with plugin=path, I have to manually switch with positions.

Turns out the multiple replaces can be executed at once, so the order no longer matters.

@francislavoie
Copy link
Member

Seems sensible. This only affects --with options that have an =, right?

@WeidiDeng
Copy link
Member Author

Didn't test. But isn't the whole point of with to specify a particular module version that's different from caddy default? That's why it's called replace.

I guess with with or without = will be affected, but the build process can go smooth in more cases.

Copy link
Member

@mohammed90 mohammed90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@mohammed90 mohammed90 merged commit 743ce51 into caddyserver:master Apr 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants