Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 4-0-upgrade-guide.rst #7912

Open
wants to merge 2 commits into
base: 4.next
Choose a base branch
from
Open

Update 4-0-upgrade-guide.rst #7912

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13d95ac
Update 4-0-upgrade-guide.rst
yosus Sep 3, 2024
9f841e7
Update en/appendices/4-0-upgrade-guide.rst
yosus Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions en/appendices/4-0-upgrade-guide.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,13 +89,17 @@ composer commands:
php composer.phar require --dev --update-with-dependencies "phpunit/phpunit:^8.0"
php composer.phar require --update-with-dependencies "cakephp/cakephp:4.0.*"

Application.php
Others
===============

Next, ensure your ``src/Application.php`` has been updated to have the same
method signatures as the one found in cakephp/app. You can find the current
`Application.php
<https://github.com/cakephp/app/blob/4.x/src/Application.php>`__ on GitHub.
Next, ensure your files have been updated to have the same
method signatures as those found in cakephp/app.

#. ``src/Application.php`` at `Application.php <https://github.com/cakephp/app/blob/4.x/src/Application.php>`__ on GitHub.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use links to the 4.0.4 tag, not 4.x

4.x is current CakePHP 4.5 which should not be used as a base to upgrade Cake 3 to.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also just reference the whole app template as it is done in the 5.0 upgrade guide instead of manually listing all the files

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the links for 4.0.0 tag be used, or 4.0.4 ?
Since it is only a few files that needs to be updated, I thought referencing them directly would be faster for users to upgrade.

#. ``config/app.php`` at `app.php <https://github.com/cakephp/app/blob/4.x/config/app.php>`__ on GitHub.
#. ``config/bootstrap.php`` at `bootstrap.php <https://github.com/cakephp/app/blob/4.x/config/bootstrap.php>`__ on GitHub.
#. ``config/paths.php`` at `paths.php <https://github.com/cakephp/app/blob/4.x/config/paths.php>`__ on GitHub, where ``RESOURCES`` needs to be defined.
#. ``config/routes.php`` at `routes.php <https://github.com/cakephp/app/blob/4.x/config/routes.php>`__ on GitHub.

If you are providing some kind of REST API, don't forget to include the
:ref:`body-parser-middleware`. Finally, you should consider upgrading to the new
Expand Down
Loading