fix: prevent to load script again

[hosseinmd]

#749

Summary

In this PR, I prevented loadScript to load scripts is loaded before

Test plan

This is happening in remote federation with huge size of script and too many modules

[changeset-bot]

⚠️ No Changeset found

Latest commit: 6d6605b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
repack-website	⬜️ Ignored (Inspect)	Visit Preview		Sep 21, 2024 11:31am

[jbroma]

Hey @hosseinmd, sorry for the late reply but I was unavailable most of the week.

The concept introduced in this PR looks great, we definitely want this in the next major (5.0) release!

Can you please add some tests for this scenarios? We need to document this behaviour as well as we can

I've also noticed that we're using the same variable
sriptsPromises for both prefetching and loading - while in theoery these should not overlap, I would go with creating a separate variables to avoid potential collision in rare edge cases.

We also need to address housekeeping of the promises that have already been fulfilled - we should remove the entires from scriptsPromises that are not relevant anymore.

Last thing that comes to my mind: perhaps we could return a promise in prefetchScript and loadScript instead of executing loadProcess again after awaiting the previous promise?