Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CIP relative links: build script fails when not anchored in current directory #1121

Closed
rphair opened this issue Aug 2, 2023 · 6 comments
Closed

CIP relative links: build script fails when not anchored in current directory #1121

rphair opened this issue Aug 2, 2023 · 6 comments
Assignees
@rphair @katomm @fill-the-fill
Labels
bug Something isn't working

Comments

@rphair
Copy link
Collaborator

rphair commented Aug 2, 2023

Happening now that cardano-foundation/CIPs#242 is merged (yesterday) into their master branch and will affect all builds from our staging branch until a fix is merged. Most notably affecting #1005 and will affect anything else built via the CI more recently. I'll submit a fix for this upstream and report back here.
@rphair rphair self-assigned this Aug 2, 2023
@rphair
Copy link
Collaborator Author

rphair commented Aug 2, 2023

Will be fixed upstream when cardano-foundation/CIPs#574 is merged.

@rphair rphair closed this as completed Aug 2, 2023
@katomm
Copy link
Member

katomm commented Aug 2, 2023

Thank you @rphair for bringing this also to the developer portal. As written in the other issue, the portal must not rely on it, and the script must not be so fragile.

@katomm katomm reopened this Aug 2, 2023
@katomm katomm mentioned this issue Aug 2, 2023
Merged
@katomm katomm self-assigned this Aug 2, 2023
@katomm
Copy link
Member

katomm commented Aug 2, 2023

@rphair I have yet to test through all the possible cases, but from what I can see, #1122 should fix or significantly improve the problem.

@rphair rphair changed the title CIP-50 merge causes Docusaurus to fail on asset links CIP build script fails on relative links not anchored in current directory Aug 2, 2023
@rphair
Copy link
Collaborator Author

rphair commented Aug 2, 2023

OK, since this has been reopened for the more general case I'm retitling it accordingly 🤓

@rphair rphair added the bug Something isn't working label Aug 2, 2023
@fill-the-fill fill-the-fill self-assigned this Aug 10, 2023
@rphair
Copy link
Collaborator Author

rphair commented Mar 20, 2024 •
edited
Loading

@katomm @fill-the-fill cross-referencing #1229.

@rphair rphair mentioned this issue Mar 20, 2024
Open
@rphair rphair changed the title CIP build script fails on relative links not anchored in current directory CIP relative links: build script fails when not anchored in current directory Mar 24, 2024
@rphair
Copy link
Collaborator Author

rphair commented Jun 2, 2024

This has been getting some visibility with the newer #1262 and I've been watching for CIP related build failures for a while, I believe this issue indeed has been fixed by #1122. cc @fill-the-fill @katomm

@rphair rphair closed this as completed Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rphair rphair

@katomm katomm

@fill-the-fill fill-the-fill

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rphair @katomm @fill-the-fill