-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incorrect colors on keys/variables #189
Comments
so interestingly, after a bit of trying to fiddle with the theme myself it seems as though setting |
Hey thanks for reporting this! The face used for colouring the attributes in nix-ts-mode is Here's an example of some C code with There are two issues here: first, being that the Catppuccin theme does not style property faces (font-lock-property-name-face inherits from font-lock-variable-name-face); second, being the abuse of faces by modes. Faces such as Essentially on our side we should patch in support for |
yes, I also noticed this thing with a lot of other ts modes as well, observed this in both json ts mode and also toml ts mode as well |
also yes I do agree that having |
I'd have to look into what faces those modes are using, it's especially difficult when different modes use faces for different things |
as per the catppuccin docs, the keys/properties are supposed to be blue right?
for eg on nix for vscode, we get the blue color:
however on emacs we get normal white color like this:
as per catppuccin style guide it should be blue
another example with json:
vscode:
Emacs:
infact even the brackets dont seem to be themed correctly
I already have the ts mode enabled for both as well
One thing I am confused with,is the ts-modes somehow causing issues?
The text was updated successfully, but these errors were encountered: