Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start workspace without asking when pressing the play button #331

Open
code-asher opened this issue Jul 30, 2024 · 0 comments
Open

Start workspace without asking when pressing the play button #331

code-asher opened this issue Jul 30, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@code-asher
Copy link
Member

code-asher commented Jul 30, 2024

Currently, the play button immediately calls out to the remote SSH plugin.

Then, our plugin hooks into the remote SSH plugin activation and it does its magic like starting the workspace.

Problem is, we cannot tell if the remote SSH plugin was activated due to the play button being pressed or due to a reconnect. We cannot auto-start on reconnects because it causes issues with auto-stopped workspaces (VS Code will keep reconnecting and keep turning workspaces on, preventing the cost savings).

So, assuming there is no clever way to tell what caused the connect, I think we will just have to duplicate the start code when you press that button. Then delegate to the remote SSH plugin.

Another case where you probably want the workspace to start without asking is from the recents menu, but that goes straight to the remote SSH plugin so I am not sure there is anything we can do there. Is there some way in the remote authority activation hook to tell what caused the connect? If we can distinguish between a first connect and a reconnect, that would be ideal.

Another case is when coming in from the dashboard. This could be handled like the play button by duplicating the start code.

@coder-labeler coder-labeler bot added the enhancement New feature or request label Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant